Merge pull request #285 from chillenzer/update-pre-commit

Update pre commit
alpaka-group · Feb 6, 2025 · a35207d · a35207d
2 parents 47f00cb + 32284d8
commit a35207d
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 14 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -2,12 +2,12 @@ minimum_pre_commit_version: 3.2.0 # necessitated by Lucas-C's hooks
 default_install_hook_types: [pre-commit, pre-push]
 repos:
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v18.1.8
+    rev: v19.1.7
     hooks:
       - id: clang-format
         files: \.(cpp|hpp)
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v5.0.0
     hooks:
       - id: no-commit-to-branch
         args: [-b, dev]
@@ -21,7 +21,7 @@ repos:
       - id: check-executables-have-shebangs
       - id: check-shebang-scripts-are-executable
   - repo: https://github.com/Lucas-C/pre-commit-hooks
-    rev: v1.5.4
+    rev: v1.5.5
     hooks:
       - id: forbid-tabs
       - id: remove-tabs
@@ -31,7 +31,7 @@ repos:
     hooks:
       - id: check-useless-excludes
   - repo: https://github.com/google/yamlfmt
-    rev: v0.13.0
+    rev: v0.15.0
     hooks:
       - id: yamlfmt
   - repo: https://github.com/adrienverge/yamllint

diff --git a/include/mallocMC/creationPolicies/FlatterScatter/AccessBlock.hpp b/include/mallocMC/creationPolicies/FlatterScatter/AccessBlock.hpp
@@ -254,7 +254,7 @@ namespace mallocMC::CreationPolicies::FlatterScatterAlloc
             auto const index = pageIndex(pointer);
             if(index >= static_cast<int32_t>(numPages()) || index < 0)
             {
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
                 throw std::runtime_error{
                     "Attempted to destroy an invalid pointer! Pointer does not point to any page."};
 #endif // NDEBUG
@@ -597,7 +597,8 @@ namespace mallocMC::CreationPolicies::FlatterScatterAlloc
                 startIndex,
                 numPages(),
                 noFreePageFound(),
-                [this, numBytes, &chunkSizeCache](auto const& localAcc, auto const index) {
+                [this, numBytes, &chunkSizeCache](auto const& localAcc, auto const index)
+                {
                     return this->thisPageIsSuitable(localAcc, index, numBytes, chunkSizeCache) ? index
                                                                                                : noFreePageFound();
                 });

diff --git a/include/mallocMC/creationPolicies/FlatterScatter/PageInterpretation.hpp b/include/mallocMC/creationPolicies/FlatterScatter/PageInterpretation.hpp
@@ -151,15 +151,15 @@ namespace mallocMC::CreationPolicies::FlatterScatterAlloc
         {
             if(chunkSize == 0)
             {
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
                 throw std::runtime_error{
                     "Attempted to destroy a pointer with chunkSize==0. Likely this page was recently "
                     "(and potentially pre-maturely) freed."};
 #endif // NDEBUG
                 return;
             }
             auto chunkIndex = chunkNumberOf(pointer);
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
             if(not isValid(acc, chunkIndex))
             {
                 throw std::runtime_error{"Attempted to destroy an invalid pointer! Either the pointer does not point "

diff --git a/include/mallocMC/distributionPolicies/XMallocSIMD.hpp b/include/mallocMC/distributionPolicies/XMallocSIMD.hpp
@@ -135,7 +135,7 @@ namespace mallocMC
                 // within one page necessary for offset calculation
                 bool const coalescible = bytes > 0 && bytes < (pagesize / 32);
 
-#if(MALLOCMC_DEVICE_COMPILE)
+#if (MALLOCMC_DEVICE_COMPILE)
                 threadcount = alpaka::popcount(alpaka::warp::ballot(acc, coalescible));
 #else
                 threadcount = 1; // TODO

diff --git a/include/mallocMC/mallocMC_utils.hpp b/include/mallocMC/mallocMC_utils.hpp
@@ -50,7 +50,7 @@
  * only is used to detect the device compile path.
  * Since we require devices with support for ballot we can high-jack __HIP_ARCH_HAS_WARP_BALLOT__.
  */
-#if(defined(__HIP_ARCH_HAS_WARP_BALLOT__) || defined(__CUDA_ARCH__) || __HIP_DEVICE_COMPILE__ == 1)
+#if (defined(__HIP_ARCH_HAS_WARP_BALLOT__) || defined(__CUDA_ARCH__) || __HIP_DEVICE_COMPILE__ == 1)
 #    define MALLOCMC_DEVICE_COMPILE 1
 #endif
 
@@ -66,7 +66,7 @@ namespace mallocMC
 #endif
 
 #ifdef ALPAKA_ACC_GPU_HIP_ENABLED
-#    if(HIP_VERSION_MAJOR >= 4)
+#    if (HIP_VERSION_MAJOR >= 4)
     template<typename TDim, typename TIdx>
     constexpr uint32_t warpSize<alpaka::AccGpuHipRt<TDim, TIdx>> = __AMDGCN_WAVEFRONT_SIZE;
 #    else

diff --git a/test/unit/source/AccessBlock.cpp b/test/unit/source/AccessBlock.cpp
@@ -295,7 +295,7 @@ TEMPLATE_LIST_TEST_CASE("AccessBlock", "", AccessBlocks)
             // the bit mask. Thus, the following test would corrupt the bit mask, if we were to allocate this in
             // chunked mode.
 
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
             REQUIRE(sizeof(BitMaskStorageType<>) > 1U);
             auto localChunkSize = pageSize - 1U;
             auto slots = accessBlock.getAvailableSlots(accSerial, localChunkSize);
@@ -469,7 +469,7 @@ TEMPLATE_LIST_TEST_CASE("AccessBlock", "", AccessBlocks)
 
         SECTION("no invalid pointer but throws instead.")
         {
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
             pointer = nullptr;
             CHECK_THROWS(
                 accessBlock.destroy(accSerial, pointer),

diff --git a/test/unit/source/PageInterpretation.cpp b/test/unit/source/PageInterpretation.cpp
@@ -227,7 +227,7 @@ TEST_CASE("PageInterpretation.destroy")
     PageInterpretation<pageSize> page{data, chunkSize};
     auto* pointer = page.create(accSerial);
 
-#if(!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
+#if (!defined(NDEBUG) && !BOOST_LANG_CUDA && !BOOST_LANG_HIP)
     SECTION("throws if given an invalid pointer.")
     {
         pointer = nullptr;