Skip to content

feat(trading): align option contract schemas#736

Open
carlostasada wants to merge 3 commits into
masterfrom
ctasada/schema-option-models
Open

feat(trading): align option contract schemas#736
carlostasada wants to merge 3 commits into
masterfrom
ctasada/schema-option-models

Conversation

@carlostasada

Copy link
Copy Markdown
Contributor

What

Aligns option contract, deliverable, and contract-query schemas with the current Trading API specification.

Why

This option-focused extraction from #698 isolates public contract changes and settlement validation for independent review.

Changes

  • Adds option contract status, style, type, and settlement enums.
  • Adds typed option deliverables and validates delayed-settlement amount rules.
  • Aligns option contract response fields and request serialization.
  • Documents new public symbols and adds compatibility and route coverage.

Breaking changes

  • Option contract deliverables are now typed rather than accepted as arbitrary values.
  • Selected fields follow the current API's required/nullability contract.

Testing

  • Full suite: 257 passed on Python 3.11.
  • Focused option tests: 26 passed.
  • Black and warnings-fatal Sphinx build passed.

Desired feedback

Please focus on deliverable settlement validation, field optionality, and exact query serialization.

Checklist

  • 323 changed lines, below the split cap
  • Full and focused tests pass
  • Formatting and documentation build pass
  • Public API changes documented

References

Made with Cursor

carlostasada and others added 3 commits July 14, 2026 11:36
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@carlostasada carlostasada self-assigned this Jul 14, 2026
@carlostasada
carlostasada marked this pull request as ready for review July 14, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant