feat(signer-trezor): add TrezorTestnet derivation path preset - #4148
Open
mehmetkr-31 wants to merge 2 commits into
Open
feat(signer-trezor): add TrezorTestnet derivation path preset#4148mehmetkr-31 wants to merge 2 commits into
mehmetkr-31 wants to merge 2 commits into
Conversation
mehmetkr-31
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
August 16, 2026 19:15
53gur0
reviewed
Aug 20, 2026
| /// Formerly used by Trezor Suite for testnets (e.g. Sepolia, Goerli, Holesky). | ||
| /// Note: Trezor Suite now defaults Sepolia to the standard Ethereum path `m/44'/60'/0'/0/<index>`, | ||
| /// but accounts previously created with the testnet path use this derivation. | ||
| TrezorTestnet(usize), |
There was a problem hiding this comment.
Maybe also call it TrezorLegacyTestnet and remove second part of the comment
Author
There was a problem hiding this comment.
Done in d624c33 — renamed to TrezorLegacyTestnet and updated the doc comment. Thanks!
Address review feedback from @53gur0: - Rename DerivationType::TrezorTestnet to DerivationType::TrezorLegacyTestnet - Simplify doc comment to focus on legacy testnet derivation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4140.
Trezor Suite previously used the testnet derivation path
m/44'/1'/0'/0/<index>(coin type1) for testnets like Sepolia, Goerli, and Holesky. While Trezor Suite recently updated Sepolia to use the standard Ethereum coin type (m/44'/60'/0'/0/<index>), previously created and funded accounts on the testnet path should still be easily accessible via a first-class derivation preset.Solution
DerivationType::TrezorTestnet(usize)corresponding tom/44'/1'/0'/0/<index>toalloy-signer-trezor.PartialEq, EqonDerivationTypeto align withalloy-signer-ledger.DerivationTypedisplay formatting andTrezorSigner::convert_pathBIP32 path derivation.PR Checklist