fix(filter): matches_block should not bypass block hash check #3677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FilterBlockOption is AtBlockHash, matches_block_range() implicitly returns true (no range bounds to check), which short-circuits the OR in matches_block() and makes the block hash constraint a no-op.
e.g. filter set to at_block_hash(0xaaa...), calling matches_block({ number: 99, hash: 0xbbb... }):
Switch to matching on the block option variant directly so AtBlockHash only checks the hash and Range only checks the number range.