Skip to content

Conversation

@sashaodessa
Copy link

retry each block number in NewBlocks before advancing to the next; break out of the fill loop only after exhausting retries for that block

}
};
let Some(block) = block else {
break 'fill;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just continue here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just continue here?

@mattsse We need to break out of the loop once the per-number retries are exhausted. Continuing here would skip over the missing block, leaving a hole at self.next_yield; newer blocks would pile up in the cache but couldn’t be yielded until that hole is filled, so we’d waste RPC calls and still block the stream. The previous implementation also break’d on an unrecoverable failure, so this keeps the same behaviour while making the retry budget actually per block.

@github-project-automation github-project-automation bot moved this to In Progress in Alloy Nov 23, 2025
@sashaodessa sashaodessa requested a review from mattsse November 24, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants