Repository navigation
Fix block stream retry logic for sequential fetching - #3227
Closed
sashaodessa wants to merge 3 commits into
Closed
sashaodessa wants to merge 3 commits into
sashaodessa wants to merge 3 commits into
Conversation
sashaodessa
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
November 21, 2025 11:31
mattsse
requested changes
Nov 23, 2025
| } | ||
| }; | ||
| let Some(block) = block else { | ||
| break 'fill; |
Member
There was a problem hiding this comment.
I think this should just continue here?
Author
There was a problem hiding this comment.
I think this should just continue here?
@mattsse We need to break out of the loop once the per-number retries are exhausted. Continuing here would skip over the missing block, leaving a hole at self.next_yield; newer blocks would pile up in the cache but couldn’t be yielded until that hole is filled, so we’d waste RPC calls and still block the stream. The previous implementation also break’d on an unrecoverable failure, so this keeps the same behaviour while making the retry budget actually per block.
Member
|
Closing as superseded by #3698, which merged on February 17, 2026 and already fixes this retry logic on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retry each block number in
NewBlocksbefore advancing to the next; break out of the fill loop only after exhausting retries for that block