Repository navigation
ci: build the workspace before the release verification step - #32
Merged
Merged
Conversation
The release workflow ran lint, typecheck and tests straight after install. The PostgreSQL indexer resolves @eclesia/indexer-engine through the engine's package entry points, which point at dist/, so on a clean runner its typecheck failed with TS2307 and the release job never reached the changesets step. Build first, as the CI workflow already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow failed on its first run after #31 was merged. Its Verify step ran lint, typecheck and tests immediately after install, but the PostgreSQL indexer resolves
@eclesia/indexer-enginethrough the engine's package entry points, which point atdist/. On a clean runner the typecheck failed with TS2307 and the job never reached the changesets step, so the version PR was not opened.This adds a build step before Verify, the same ordering the CI workflow already uses. The publish script (
pnpm build && changeset publish) was already building before publishing, so published packages were never at risk.Verification
main, so its first successful run will be on the merge of this PR. It should then open the "chore: version packages" pull request from the 25 pending changesets.