Adding the bulk of the feature #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogmarsh
approved these changes
Dec 20, 2022
Contributor
mogmarsh
left a comment
mogmarsh
left a comment
There was a problem hiding this comment.
a few little things. Overall 👍
| protected function ul( DOMNode $node ): Block { | ||
| return new Block( | ||
| block_name: 'list', | ||
| content: static::get_node_html( $node ), |
Contributor
There was a problem hiding this comment.
WordPress 6.1 introduces a list item block
WordPress/gutenberg#42711
| attributes: [ | ||
| 'ordered' => true, | ||
| ], | ||
| content: static::get_node_html( $node ), |
Contributor
There was a problem hiding this comment.
same on the list item blocks WordPress/gutenberg#42711
| */ | ||
| protected function minify_block( $block ) { | ||
| if ( preg_match( '/(\s){2,}/s', $block ) === 1 ) { | ||
| return preg_replace( '/(\s){2,}/s', '', $block ); |
Contributor
There was a problem hiding this comment.
do we want to replace with '' or ' '?
Comment on lines
+345
to
+368
| '<!-- wp:html --> | ||
| <div></div> | ||
| <!-- /wp:html -->', | ||
| '<!-- wp:paragraph --> | ||
| <div> </div> | ||
| <!-- /wp:paragraph -->', | ||
| '<!-- wp:html --> | ||
| <div> </div> | ||
| <!-- /wp:html -->', | ||
| '<!-- wp:paragraph --> | ||
| <div> </div> | ||
| <!-- /wp:paragraph -->', | ||
| '<!-- wp:paragraph --><p><br></p><!-- /wp:paragraph -->', | ||
| '<!-- wp:paragraph --><p><br><br><br></p><!-- /wp:paragraph -->', | ||
| '<!-- wp:paragraph --> | ||
| <p><br></p> | ||
| <!-- /wp:paragraph -->', | ||
| '<!-- wp:html --> | ||
| <div> </div> | ||
| <!-- /wp:html -->', | ||
| '<!-- wp:heading {"level":3} --> | ||
| <h3> | ||
| </h3> | ||
| <!-- /wp:heading -->', |
Contributor
There was a problem hiding this comment.
I feel like there should be a better way to do this, but good enough for now...
Member
Author
There was a problem hiding this comment.
Yeah... I didn't write this part 🙉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the feature from Alleypack to be used in open-source packages.