Skip to content

Allow end user to define a label for the empty option in a select #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anubisthejackle wants to merge 3 commits into
base: main
Choose a base branch
from
+30 −1
Open

Allow end user to define a label for the empty option in a select #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37e1779
Allow end user to define a label for the empty option in a select
anubisthejackle Mar 20, 2021
f215cd2
Update property name, and add unit test
anubisthejackle Mar 22, 2021
b79347b
Update php/class-fieldmanager-select.php
anubisthejackle Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion php/class-fieldmanager-select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ class Fieldmanager_Select extends Fieldmanager_Options {
*/
public $first_empty = false;

/**
* String to use for first empty element.
*
* @var string
*/
public $first_empty_label = ' ';

/**
* Tell FM to save multiple values.
*
Expand Down Expand Up @@ -120,7 +127,7 @@ public function form_element( $value = array() ) {

$opts = '';
if ( $this->is_repeatable() || $this->first_empty ) {
$opts .= '<option value="">&nbsp;</option>';
$opts .= '<option value="">' . esc_html( $this->first_empty_label ) . '</option>';
}
$opts .= $this->form_data_elements( $value );

Expand Down
22 changes: 22 additions & 0 deletions tests/php/test-fieldmanager-select-field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,28 @@ public function test_first_empty() {
);
}

public function test_first_empty_label() {
$fm = new Fieldmanager_Select(
array(
'name' => 'base_field',
'options' => array( 'one', 'two', 'three' ),
'first_empty' => true,
'first_empty_label' => '-- Empty --',
)
);

$html = $this->_get_html_for( $fm );
$this->assertRegExp(
'#<select[^>]+>'
. '\s*<option value="">-- Empty --</option>'
. '\s*<option value="one"\s*>one</option>'
. '\s*<option value="two"\s*>two</option>'
. '\s*<option value="three"\s*>three</option>'
. '\s*</select>#si',
$html
);
}

public function test_default_value() {
$fm = new Fieldmanager_Select(
array(
Expand Down