DIVE-131 Add Gutenberg support for dynamic fields #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodguyry
approved these changes
Jul 17, 2018
| @@ -1,5 +1,34 @@ | |||
| var fm = {}; | |||
|
|
|||
| /** | |||
| * Polyfill Element.matches, if necessary. | |||
| * @see https://developer.mozilla.org/en-US/docs/Web/API/Element/closest#Polyfill | |||
There was a problem hiding this comment.
The link should be https://developer.mozilla.org/en-US/docs/Web/API/Element/matches#Polyfill
There was a problem hiding this comment.
This specific matches polyfill was taken from the closest polyfill page, which is slightly different from the one present on the matches polyfill page you linked above. I'm only including it because closest depends on it, so I'm pulling both polyfills from the same location. Good catch, though!
benpbolton
force-pushed
the
DIVE-131-gutenberg-datepicker
branch
from
ad1701e to
9c95ec0
Compare
Closed
# Conflicts: # .gitignore # package.json
|
@kevinfodness Just tested this locally and it works great to fix the autocomplete bug. Any idea if/when this will be merged? |
|
Closing in favor of #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:visible.Element.matchesandElement.closestto efficiently enable the parent check.package.lockfor Node modules.Fixes #713
Fixes #710