Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply accelerate change to dpo cache script #507

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Apply accelerate change to dpo cache script #507

merged 2 commits into from
Jan 10, 2025

Conversation

hamishivi
Copy link
Collaborator

@hamishivi hamishivi commented Jan 10, 2025 •
edited
Loading

#492 updated some stuff and accelerate call needed to be updated. This should fix.
Also fix the bug where accelerator.is_main_process == 0 should be accelerator.is_main_process

@hamishivi hamishivi requested a review from vwxyzjn January 10, 2025 18:09
vwxyzjn
vwxyzjn approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!!

@vwxyzjn vwxyzjn merged commit 5ba0470 into main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vwxyzjn vwxyzjn vwxyzjn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishivi @vwxyzjn