push

allenai · Aug 29, 2024 · ec8988b · ec8988b
1 parent b2e071d
commit ec8988b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 20 deletions.
diff --git a/.github/workflows/push-image-olmo.yml b/.github/workflows/push-image-olmo.yml
@@ -23,14 +23,14 @@ on:
       - '.github/workflows/push-image-olmo.yml'
       # Note, add .olmo dockerfile + requirements if adding auto build to those
     branches: [main]
-  pull_request: # note, comment this out for running on every push
-    # Also run on PRs that update the files in the image's directory (other than README).
-    branches: [main]
-    paths:
-      - 'open_instruct/**'
-      - '!open_instruct/README.md'
-      - 'requirements-olmo.txt'
-      - 'Dockerfile.olmo'
+  # pull_request: # note, comment this out for running on every push
+  #   # Also run on PRs that update the files in the image's directory (other than README).
+  #   branches: [main]
+  #   paths:
+  #     - 'open_instruct/**'
+  #     - '!open_instruct/README.md'
+  #     - 'requirements-olmo.txt'
+  #     - 'Dockerfile.olmo'
   workflow_dispatch:  # This allows us to manually trigger a build through the GitHub UI.
 
 env:

diff --git a/.github/workflows/push-image.yml b/.github/workflows/push-image.yml
@@ -31,7 +31,6 @@ on:
       - '!open_instruct/README.md'
       - 'requirements.txt'
       - 'Dockerfile'
-      - .github/workflows/push-image.yml
   workflow_dispatch:  # This allows us to manually trigger a build through the GitHub UI.
 
 env:
@@ -56,24 +55,24 @@ jobs:
       # big images fail, trying this
       - name: Delete huge unnecessary tools folder
         run: rm -rf /opt/hostedtoolcache /usr/share/dotnet "$AGENT_TOOLSDIRECTORY"
-  
+
       - name: Build and push
         uses: docker/build-push-action@v6
         with:
           context: .
           cache-from: type=gha
           cache-to: type=gha,mode=max
-        build-args: |
-          BUILDKIT_INLINE_CACHE=1
-          CUDA=12.1.0
-          TARGET=cudnn8-devel
-          DIST=ubuntu20.04
-          REQUIRE=requirements.txt
-        tags: open_instruct
+          build-args: |
+            BUILDKIT_INLINE_CACHE=1
+            CUDA=12.1.0
+            TARGET=cudnn8-devel
+            DIST=ubuntu20.04
+            REQUIRE=requirements.txt
+          tags: open_instruct
 
-      # - name: Check image
-      #   run: |
-      #     docker run --rm open_instruct
+      - name: Check image
+        run: |
+          docker run --rm open_instruct
 
       # - name: Push image
       #   # if: github.event_name != 'pull_request'