Fix auto save logic (#519)

allenai · Jan 15, 2025 · 4365dea · 4365dea
1 parent 2a1eaaf
commit 4365dea
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/open_instruct/dpo_tune.py b/open_instruct/dpo_tune.py
@@ -1124,7 +1124,7 @@ def load_model():
         args.try_auto_save_to_beaker
         and accelerator.is_main_process
         and len(beaker_config.beaker_dataset_id_urls) > 0
-        and args.output_dir != "/output"
+        and args.output_dir.rstrip("/") != "/output"
     ):
         shutil.copytree(args.output_dir, "/output", dirs_exist_ok=True)
 

diff --git a/open_instruct/dpo_tune_cache.py b/open_instruct/dpo_tune_cache.py
@@ -1144,7 +1144,7 @@ def load_model():
         args.try_auto_save_to_beaker
         and accelerator.is_main_process
         and len(beaker_config.beaker_dataset_id_urls) > 0
-        and args.output_dir != "/output"
+        and args.output_dir.rstrip("/") != "/output"
     ):
         shutil.copytree(args.output_dir, "/output", dirs_exist_ok=True)
 

diff --git a/open_instruct/finetune.py b/open_instruct/finetune.py
@@ -1038,7 +1038,7 @@ def main(args: FlatArguments):
         args.try_auto_save_to_beaker
         and accelerator.is_main_process
         and len(beaker_config.beaker_dataset_id_urls) > 0
-        and args.output_dir != "/output"
+        and args.output_dir.rstrip("/") != "/output"
     ):
         shutil.copytree(args.output_dir, "/output", dirs_exist_ok=True)
 

diff --git a/open_instruct/ppo_vllm_thread_ray.py b/open_instruct/ppo_vllm_thread_ray.py
@@ -1307,7 +1307,7 @@ def vllm_generate(
             args.try_auto_save_to_beaker
             and self.rank == 0
             and len(self.beaker_config.beaker_dataset_id_urls) > 0
-            and args.output_dir != "/output"
+            and args.output_dir.rstrip("/") != "/output"
         ):
             shutil.copytree(args.output_dir, "/output", dirs_exist_ok=True)
         print("finished training")

diff --git a/open_instruct/ppo_vllm_thread_ray_gtrl.py b/open_instruct/ppo_vllm_thread_ray_gtrl.py
@@ -1384,7 +1384,7 @@ def vllm_generate(
             args.try_auto_save_to_beaker
             and self.rank == 0
             and len(self.beaker_config.beaker_dataset_id_urls) > 0
-            and args.output_dir != "/output"
+            and args.output_dir.rstrip("/") != "/output"
         ):
             shutil.copytree(args.output_dir, "/output", dirs_exist_ok=True)
         print("finished training")