-
Notifications
You must be signed in to change notification settings - Fork 592
resource/alicloud_eflo_node: Added the field cluster_id, node_group_id, node_type. #9219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7b5e863 to
fa53be1
Compare
| request["ProductCode"] = "learn" | ||
| request["ProductType"] = "learn_eflocomputing_public_intl" | ||
| } | ||
| if v, ok := d.GetOk("payment_type"); ok && v == "PayAsYouGo" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方为啥还需要配置后付费的逻辑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里只要是用了bss,在配置了预付费和后付费模式的情况下都会按这个规则生成
| "node_type": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个字段应该有一个系统默认值,我配置下
| return WrapError(err) | ||
| } | ||
| } | ||
| if !d.IsNewResource() && d.HasChange("node_group_id") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node_group_id 和 cluster_id 的变更是同时的,用的是同一个 API,所以不用分开
另外,d.IsNewResource()这个判断应该去掉,如果是新创建的预付费实例,是允许扩容的;可以按照status 来判断:
- 如果 status == unused,node_group_id 或者 cluster_id 不为空,可以发起扩容
- 如果 status != unused,node_group_id 或者 cluster_id 为空,可以发起缩容
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在不支持同时变更两个属性,这部分只能手改适配了
ab60ae7 to
bb65be8
Compare
…_allocation_policy, machine_type_policy, bonds, subnet, name, machine_type, bond_policy, bond_default_subnet, node_policy, node_id, login_password, node_group_id, node_type, user_data, vswitch_id, vpc_id, Code, Value.
bb65be8 to
8e8a521
Compare
No description provided.