UI: Redesign exclusive ChoiceParam UI component #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2656 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Simplify the FilterComboBox to rely on the default behavior provided by the ComboBox control. Improve the filtering system and the ability to set a custom value. Turn to a more declarative approach with regard to handling value update and its mapping to the combobox's current index.
yann-lty
force-pushed
the
dev/choiceParamUI
branch
from
2ddfdb8 to
0d3a49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-design the UI control for editing an exclusive ChoiceParam.
Before
Behavior
Custom Value indicator
After (this PR)
Behavior
Custom value indicator
Features list
Implementation remarks
Rely as much as possible on the behaviors provided by the default ComboBox component to avoid custom logic for e.g keyboard navigation.
Move away from imperative code for handling value binding, simplifying the usage of the FilterComboBox component and making sure that the displayed value is always reflecting the actual attribute's value.
Simplify the filtering logic.