Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable merge of multiple sfmDatas #2654

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Enable merge of multiple sfmDatas #2654

merged 1 commit into from
Jan 27, 2025

Conversation

servantftechnicolor
Copy link
Contributor

See alicevision/AliceVision#1807

Previous sfmMerge was only accepting 2 sfmData.
Here we enable use of N>0 sfmData.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (1f42ad3) to head (b691308).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
meshroom/nodes/aliceVision/SfMMerge.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2654      +/-   ##
===========================================
+ Coverage    69.93%   69.96%   +0.02%     
===========================================
  Files          121      121              
  Lines         7088     7084       -4     
===========================================
- Hits          4957     4956       -1     
+ Misses        2131     2128       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiencastan fabiencastan added this to the Meshroom 2025.1.0 milestone Jan 27, 2025
@fabiencastan fabiencastan merged commit 2bd98c3 into develop Jan 27, 2025
4 of 5 checks passed
@fabiencastan fabiencastan deleted the dev/sfmMultiMerge branch January 27, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants