Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Fitting of selected Nodes in the Graph Editor when Fit is invoked #2652

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion meshroom/ui/qml/GraphEditor/GraphEditor.qml
Original file line number Diff line number Diff line change
Expand Up @@ -1203,10 +1203,42 @@ Item {
return bbox;
}

function selectionBoundingBox() {
/**
* Returns the bounding box considering the nodes which are selected.
* The returned bounding box starts from the Minumum x,y position to the
* Maximum x,y postion of the selected nodes.
*/
var firstIdx = uigraph.nodeSelection.selectedIndexes[0];
const first = nodeRepeater.itemAt(firstIdx.row);
// Bounding box of the first selected item
var bbox = Qt.rect(first.x, first.y, first.x + first.width, first.y + first.height);
// Iterate over the remaining items in the selection
uigraph.nodeSelection.selectedIndexes.forEach(function(idx) {
if(idx != firstIdx) {
const item = nodeRepeater.itemAt(idx.row);
bbox.x = Math.min(bbox.x, item.x);
bbox.y = Math.min(bbox.y, item.y);
bbox.width = Math.max(bbox.width, item.x + item.width);
bbox.height = Math.max(bbox.height, item.y + item.height);
}
});

bbox.width -= bbox.x;
bbox.height -= bbox.y;
return bbox;
}

// Fit graph to fill root
function fit() {
var bbox;
// Compute bounding box
var bbox = boundingBox()
if (uigraph.nodeSelection.hasSelection) {
bbox = selectionBoundingBox();
}
else {
bbox = boundingBox();
}
// Rescale to fit the bounding box in the view, zoom is limited to prevent huge text
draggable.scale = Math.min(Math.min(root.width / bbox.width, root.height / bbox.height), maxZoom)
// Recenter
Expand Down
Loading