[ui]: Introduction of multiple ways to remove Node Edges #2644
+324
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With PySide6 the modifiers are now enum.Flag based. Updated type ensures the alt+mouse click removes edges from graphs
This function is responsible to disconnect any edges incoming and outgoing edges from the nodes which do not lie in the current selection
…nctionality for the graph
…unctionality for the graph
Node shake is detected when the node starts changins positions after being clicked and it is tracked via a timer to consider a shake. Emits the shaked signal when the node is shaked
…isconnect nodes method
…opup to be triggered with right click
…agonal agasint the Edge Path If an edge or shape were to cut the edge, the intersection of the shake is detected by this function
This method allows removal of edges from the graph by index of the edge
The drawn edge is checked for intersection with individual node edges and any edge found interesecting is emitted when the selection ends
Upon selection end the found intersected edges gets removed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2644 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces various methods to remove Node edges within the Graph. These methods enhance the usability of the Node Graph by providing users with multiple options to managed node egde connections.
Details of the Change:
The various methods include,
Xon the KeyboardCtrlandAlton the Keyboard and Left click + Drag on the edges, this generates the EdgeSelectionLine and whatever edges this has intersected with will get removed.Features list
Implementation remarks