Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sfm pipeline to accept meshes #2642

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Update sfm pipeline to accept meshes #2642

merged 4 commits into from
Jan 20, 2025

Conversation

servantftechnicolor
Copy link
Contributor

see alicevision/AliceVision#1803

This PR add a set of features to enable use of lidar measures as smooth constraints on the landmark positions.

Assumes one frame of the sequence is correclty aligned with the lidar geometric frame.
Assumes the camera calibration is fully and precisely known.
Use Mesh generated from lidar to fetch 3D point for a given 2D landmark by point back projection.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (aeb77d8) to head (fce6ba1).
Report is 54 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2642      +/-   ##
===========================================
+ Coverage    69.90%   69.93%   +0.02%     
===========================================
  Files          121      121              
  Lines         7078     7088      +10     
===========================================
+ Hits          4948     4957       +9     
- Misses        2130     2131       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Jan 16, 2025
meshroom/nodes/aliceVision/ExportMatches.py Outdated Show resolved Hide resolved
meshroom/nodes/aliceVision/ExportMatches.py Outdated Show resolved Hide resolved
meshroom/nodes/aliceVision/RelativePoseEstimating.py Outdated Show resolved Hide resolved
meshroom/nodes/aliceVision/RelativePoseEstimating.py Outdated Show resolved Hide resolved
Update the versions for all the nodes that have been updated to
support meshes as inputs and fix the case for some labels.

Co-authored-by: Candice Bentéjac <[email protected]>
@cbentejac cbentejac added the feature new feature (proposed as PR or issue planned by dev) label Jan 17, 2025
@cbentejac cbentejac merged commit 1f42ad3 into develop Jan 20, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/sfmLidar branch January 20, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature (proposed as PR or issue planned by dev)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants