-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sfm pipeline to accept meshes #2642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2642 +/- ##
===========================================
+ Coverage 69.90% 69.93% +0.02%
===========================================
Files 121 121
Lines 7078 7088 +10
===========================================
+ Hits 4948 4957 +9
- Misses 2130 2131 +1 ☔ View full report in Codecov by Sentry. |
cbentejac
requested changes
Jan 17, 2025
cbentejac
force-pushed
the
dev/sfmLidar
branch
from
January 17, 2025 16:05
c35d34d
to
31fe07d
Compare
Update the versions for all the nodes that have been updated to support meshes as inputs and fix the case for some labels. Co-authored-by: Candice Bentéjac <[email protected]>
cbentejac
force-pushed
the
dev/sfmLidar
branch
from
January 17, 2025 16:09
31fe07d
to
fce6ba1
Compare
cbentejac
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see alicevision/AliceVision#1803
This PR add a set of features to enable use of lidar measures as smooth constraints on the landmark positions.