Allow ignoring duplicates in sfmMerge#2105
Merged
servantftransperfect merged 1 commit intodevelopfrom Apr 2, 2026
Merged
Conversation
servantftransperfect
requested review from
CedricThebault,
cbentejac,
demoulinv and
fabiencastan
servantftransperfect
force-pushed
the
dev/sfmMerge
branch
from
d04dabc to
e38058f
Compare
demoulinv
approved these changes
Apr 2, 2026
servantftransperfect
force-pushed
the
dev/sfmMerge
branch
from
e38058f to
582f6e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an option to ignore duplicate views or intrinsics during the SfM data merge process, both in the command-line interface and the Python node definition. This allows users to choose whether to throw an error or silently skip duplicates when using the
simple_copymerge method.Feature: Duplicate Handling in SfM Merge
ignoreDuplicatesboolean parameter to theSfMMergenode inSfMMerge.py, allowing users to specify whether to ignore or error on duplicate views/intrinsics when using thesimple_copymethod.simpleMergefunction inmain_sfmMerge.cppto accept anignoreDuplicatesparameter, skipping errors for duplicates if set to true. [1] [2] [3]--ignoreDuplicatescommand-line option to thesfmMergeutility, with logic to pass this parameter through to the merge function. [1] [2] [3]