Skip to content

Commit

Permalink
Comments and typos
Browse files Browse the repository at this point in the history
  • Loading branch information
servantftechnicolor committed Jan 17, 2025
1 parent 0434f1b commit bf40dfb
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 21 deletions.
6 changes: 3 additions & 3 deletions src/aliceVision/mesh/MeshIntersection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class MeshIntersection
* @param output the output measured point
* @param intrinsic the camera intrinsics to use for ray computation
* @param imageCoords the camera observation we want to use to estimate its 'depth'
* @return true if the ray intersect the mesh.
* @return true if the ray intersects the mesh.
*/
bool pickPoint(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);

Expand All @@ -44,7 +44,7 @@ class MeshIntersection
* @param output the output measured normal
* @param intrinsic the camera intrinsics to use for ray computation
* @param imageCoords the camera observation we want to use to estimate its 'depth'
* @return true if the ray intersect the mesh.
* @return true if the ray intersects the mesh.
*/
bool pickNormal(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);

Expand All @@ -54,7 +54,7 @@ class MeshIntersection
* @param normal the output measured normal
* @param intrinsic the camera intrinsics to use for ray computation
* @param imageCoords the camera observation we want to use to estimate its 'depth'
* @return true if the ray intersect the mesh.
* @return true if the ray intersects the mesh.
*/
bool pickPointAndNormal(Vec3 & point, Vec3 & normal, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);

Expand Down
2 changes: 1 addition & 1 deletion src/aliceVision/sfm/pipeline/expanding/ExpansionChunk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ void ExpansionChunk::setConstraints(sfmData::SfMData & sfmData, const track::Tra

for (const auto & [trackId, vecInfo] : infoPerLandmark)
{
if (vecInfo.size() == 0)
if (vecInfo.empty())
{
continue;
}
Expand Down
4 changes: 2 additions & 2 deletions src/aliceVision/sfm/pipeline/expanding/ExpansionChunk.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ExpansionChunk
{
public:
using uptr = std::unique_ptr<ExpansionChunk>;

public:

/**
Expand All @@ -35,7 +35,7 @@ class ExpansionChunk
const std::set<IndexT> & viewsChunk);

/**
* brief setup the bundle handler
* @brief setup the bundle handler
* @param bundleHandler a unique ptr. the Ownership will be taken
*/
void setBundleHandler(SfmBundle::uptr & bundleHandler)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ void ExpansionPolicyLegacy::rollback(const std::set<IndexT> & viewsSet)
{
for (const auto & item : viewsSet)
{
ALICEVISION_LOG_INFO("rollback view : " << item);
ALICEVISION_LOG_INFO("Rollback view : " << item);
_availableViewsIds.insert(item);
}
}
Expand Down
3 changes: 1 addition & 2 deletions src/aliceVision/sfm/pipeline/expanding/PointFetcher.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,14 @@ class PointFetcher
public:
/**
* Set the pose of the camera
* @param the pose of the camera wrt some global coordinates frame
* @param pose the pose of the camera wrt some global coordinates frame
*/
virtual void setPose(const geometry::Pose3 & pose) = 0;

/**
* @brief virtual method to get coordinates and normals of a pixel of an image
* @param point result point in some global coordinates frame
* @param normal result normal in some global coordinates frame
* @param pose pose of the camera wrt some global coordinates frame
* @param intrinsic the camera intrinsic object
* @param imageCoords the input image pixel coordinates in 2D.
* @return false on error
Expand Down
1 change: 0 additions & 1 deletion src/aliceVision/sfm/pipeline/expanding/SfmBundle.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// This file is part of the AliceVision project.
// Copyright (c) 2025 AliceVision contributors.
// Copyright (c) 2024 AliceVision contributors.
// This Source Code Form is subject to the terms of the Mozilla Public License,
// v. 2.0. If a copy of the MPL was not distributed with this file,
Expand Down
1 change: 0 additions & 1 deletion src/aliceVision/sfm/pipeline/expanding/SfmBundle.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// This file is part of the AliceVision project.
// Copyright (c) 2025 AliceVision contributors.
// Copyright (c) 2024 AliceVision contributors.
// This Source Code Form is subject to the terms of the Mozilla Public License,
// v. 2.0. If a copy of the MPL was not distributed with this file,
Expand Down
2 changes: 1 addition & 1 deletion src/aliceVision/sfm/sfmFilters.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ IndexT removeOutliersWithPixelResidualError(sfmData::SfMData& sfmData,
IndexT removeOutliersWithAngleError(sfmData::SfMData& sfmData, const double dMinAcceptedAngle);

/**
* @Brief remove all point constraints which are too far away from their associated landmark
* @brief remove all point constraints which are too far away from their associated landmark
* @param sfmData the sfmData to update
* @param maxDist the maximal allowed distance between the landmark and the constraint
* @return the number of constraints removed
Expand Down
8 changes: 4 additions & 4 deletions src/aliceVision/sfmData/SfMData.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ class SfMData
LandmarksUncertainty _landmarksUncertainty;
/// 2D Constraints
Constraints2D constraints2d;
/// Point constraintss
ConstraintsPoint constraintspoint;
/// Point constraints
ConstraintsPoint constraintsPoint;
/// Rotation priors
RotationPriors rotationpriors;

Expand Down Expand Up @@ -144,8 +144,8 @@ class SfMData
* @brief Get ConstraintsPoints
* @return ConstraintsPoints
*/
const ConstraintsPoint& getConstraintsPoint() const { return constraintspoint; }
ConstraintsPoint& getConstraintsPoint() { return constraintspoint; }
const ConstraintsPoint& getConstraintsPoint() const { return constraintsPoint; }
ConstraintsPoint& getConstraintsPoint() { return constraintsPoint; }

/**
* @brief Get RotationPriors
Expand Down
4 changes: 2 additions & 2 deletions src/software/export/main_exportMatches.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ int aliceVision_main(int argc, char** argv)
indexFilterA = sfmData.findView(filterA);
if (indexFilterA == UndefinedIndexT)
{
ALICEVISION_LOG_ERROR("Could not find corresponding view for : " + filterA);
ALICEVISION_LOG_ERROR("Could not find corresponding view for: " + filterA);
return EXIT_FAILURE;
}
}
Expand All @@ -158,7 +158,7 @@ int aliceVision_main(int argc, char** argv)
indexFilterB = sfmData.findView(filterB);
if (indexFilterB == UndefinedIndexT)
{
ALICEVISION_LOG_ERROR("Could not find corresponding view for : " + filterB);
ALICEVISION_LOG_ERROR("Could not find corresponding view for: " + filterB);
return EXIT_FAILURE;
}
}
Expand Down
5 changes: 2 additions & 3 deletions src/software/pipeline/main_sfmExpanding.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class MeshPointFetcher : public sfm::PointFetcher
}

/**
* Set the pose of the camera
* @param the pose of the camera wrt some global coordinates frame
* @brief Set the pose of the camera
* @param pose the pose of the camera wrt some global coordinates frame
*/
void setPose(const geometry::Pose3 & pose) override
{
Expand All @@ -60,7 +60,6 @@ class MeshPointFetcher : public sfm::PointFetcher
* @brief virtual method to get coordinates and normals of a pixel of an image
* @param point result point in some global coordinates frame
* @param normal result normal in some global coordinates frame
* @param pose pose of the camera wrt some global coordinates frame
* @param intrinsic the camera intrinsic object
* @param imageCoords the input image pixel coordinates in 2D.
* @return false on error
Expand Down

0 comments on commit bf40dfb

Please sign in to comment.