Skip to content

feat: optimizations for dense models on ROCM/AMD #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 23, 2025
Merged

feat: optimizations for dense models on ROCM/AMD #204

merged 14 commits into from
Oct 23, 2025

Conversation

@DorianZi
Copy link
Collaborator

@DorianZi DorianZi commented Oct 10, 2025

No description provided.

@DorianZi DorianZi requested a review from LLLLKKKK October 10, 2025 02:09
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DorianZi DorianZi changed the title optimizations for dense models on ROCM/AMD feat: optimizations for dense models on ROCM/AMD Oct 10, 2025
LLLLKKKK
LLLLKKKK requested changes Oct 10, 2025
View reviewed changes
LLLLKKKK
LLLLKKKK reviewed Oct 10, 2025
View reviewed changes
LLLLKKKK
LLLLKKKK requested changes Oct 10, 2025
View reviewed changes
@amd-yilizhao amd-yilizhao force-pushed the develop/qwen3-rocm-main_more_opt branch from e4c77f2 to 688ee2d Compare October 13, 2025 05:59
LLLLKKKK
LLLLKKKK requested changes Oct 13, 2025
View reviewed changes
@LLLLKKKK
Copy link
Collaborator

LLLLKKKK commented Oct 13, 2025

需要增加 smoke 测试

@DorianZi DorianZi force-pushed the develop/qwen3-rocm-main_more_opt branch 4 times, most recently from 4544c0e to eea02b6 Compare October 15, 2025 07:58
@DorianZi
Copy link
Collaborator Author

DorianZi commented Oct 15, 2025

需要增加 smoke 测试
Done

  1. 已增加swizzle、fp8 attention的测试到open_merge/204
  2. 其它优化（norm, attention, rotary embeding等）已经默认打开，原有smoke可以覆盖

@LLLLKKKK LLLLKKKK mentioned this pull request Oct 15, 2025
Closed
LLLLKKKK
LLLLKKKK requested changes Oct 15, 2025
View reviewed changes
@DorianZi DorianZi force-pushed the develop/qwen3-rocm-main_more_opt branch 2 times, most recently from 90118ef to 6d3697a Compare October 16, 2025 05:46
@liaocz liaocz force-pushed the develop/qwen3-rocm-main_more_opt branch 3 times, most recently from f2d3c6c to 78652a1 Compare October 16, 2025 07:52
@DorianZi DorianZi force-pushed the develop/qwen3-rocm-main_more_opt branch from 78652a1 to 0390b98 Compare October 16, 2025 11:39
yhalpha
yhalpha reviewed Oct 17, 2025
View reviewed changes
@LLLLKKKK LLLLKKKK enabled auto-merge (rebase) October 20, 2025 04:41
LLLLKKKK
LLLLKKKK requested changes Oct 20, 2025
View reviewed changes
LLLLKKKK
LLLLKKKK requested changes Oct 20, 2025
View reviewed changes
LLLLKKKK
LLLLKKKK requested changes Oct 21, 2025
View reviewed changes
@hangy-amd hangy-amd force-pushed the develop/qwen3-rocm-main_more_opt branch from 2520022 to 6083468 Compare October 22, 2025 04:08
@LLLLKKKK LLLLKKKK merged commit 08ad962 into main Oct 23, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianglan89 jianglan89 jianglan89 left review comments

@zhiqchen-amd zhiqchen-amd zhiqchen-amd left review comments

@hangy-amd hangy-amd hangy-amd left review comments

@amd-yilizhao amd-yilizhao amd-yilizhao left review comments

@LLLLKKKK LLLLKKKK LLLLKKKK approved these changes

+1 more reviewer

@yhalpha yhalpha yhalpha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.