Skip to content

refactor: rename and adjust auto_clear_time property, resovles #38 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengwx2009 merged 1 commit into from
Nov 11, 2025
Merged

refactor: rename and adjust auto_clear_time property, resovles #38 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rock/admin/proto/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def transform(self):
from rock.rocklet.proto.request import InitDockerEnvRequest

res = InitDockerEnvRequest(**self.model_dump())
res.auto_clear_time = self.auto_clear_time_minutes
return res


Expand Down
6 changes: 5 additions & 1 deletion rock/deployments/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class DockerDeploymentConfig(DeploymentConfig):
remove_container: bool = True
"""Whether to remove the container after it stops running."""

auto_clear_time: int = 30
auto_clear_time_minutes: int = 30
"""Automatic container cleanup time in minutes."""

memory: str = "8g"
Expand Down Expand Up @@ -145,6 +145,10 @@ def get_deployment(self) -> AbstractDeployment:

return DockerDeployment.from_config(self)

@property
def auto_clear_time(self) -> int:
return self.auto_clear_time_minutes


class RayDeploymentConfig(DockerDeploymentConfig):
"""Configuration for Ray-based distributed deployment."""
Expand Down
Loading