Skip to content

refine model service logs #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephenRi merged 1 commit into from
Dec 17, 2025
Merged

refine model service logs #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rock/sdk/model/server/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""LLM Service - FastAPI server for sandbox communication."""
import asyncio
import logging
import uuid
from contextlib import asynccontextmanager
from pathlib import Path
Expand All @@ -11,12 +10,12 @@
from fastapi import FastAPI, HTTPException, Request, status
from fastapi.responses import JSONResponse

from rock.logger import init_logger
from rock.sdk.model.server.config import LOG_FILE, SERVICE_HOST, SERVICE_PORT
from rock.sdk.model.server.file_handler import FileHandler

# Configure logging
logging.basicConfig(level=logging.INFO, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s")
logger = logging.getLogger(__name__)
logger = init_logger(__name__)

# Global request counter
request_counter = 0
Expand Down
5 changes: 4 additions & 1 deletion tests/integration/cli/test_model_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
async def test_model_service():
os.environ["ROCK_MODEL_SERVICE_DATA_DIR"] = "/tmp/rock_model_service_test_data"

subprocess.run(["rock", "model-service", "start"])
model_env = os.environ.copy()
model_env["ROCK_LOGGING_PATH"] = "/tmp/rock_model_service_test_data"
model_env["ROCK_LOGGING_FILE_NAME"] = "model_service.log"
subprocess.run(["rock", "model-service", "start"], env=model_env)

mock_agent_process = subprocess.Popen(["sleep", "200"])
agent_pid = mock_agent_process.pid
Expand Down
Loading