Skip to content

refactor: prevent logger propagation in init_logger function #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BCeZn merged 1 commit into from
Dec 17, 2025
Merged

refactor: prevent logger propagation in init_logger function #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rock/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ def init_logger(name: str | None = None):
logger.addHandler(handler)
logger.setLevel(log_level)

logger.propagate = False

# Configure urllib3 specifically if this is called for the first time with appropriate logger
if logger_name in ["rock", "admin"] or logger_name.startswith("rock."):
logging.getLogger("urllib3").setLevel(logging.WARNING)
Expand Down
Loading