Boxes: Point go-algorand to boxes_response_rework #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2022
algochoi
reviewed
Jul 11, 2022
There was a problem hiding this comment.
How about we just wait for the boxes_response_rework changes to be merged into the current feature branch? I'm wondering if there is urgency to create a new PR (instead of local branch testing), since we'd have to revert it back when the parent PR needs to be merged in.
@algochoi Sounds good - I'm on-board to avoid merging the PR. Minimally, I opened the PR for visibility purposes. |
algochoi
added a commit
that referenced
this pull request
Jul 15, 2022
* Add path tests for GetApplicationBoxes * Change step name to include this application and add list box name tests * Spacing * Reduce number of redundant steps * Add query to boxes path test * Boxes: Point go-algorand to boxes_response_rework (#210) * Revert back go-algorand testing branch Co-authored-by: Michael Diamant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #208 to point go-algorand branch to algorand/go-algorand#4249. Enables SDKs to make corresponding API changes.