Skip to content

fix(numericMenu): simplify (WIP) #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Haroenv wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

fix(numericMenu): simplify (WIP) #6852

Haroenv wants to merge 1 commit into from
+46 −104

Conversation

@Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Dec 31, 2025

simplifies the numeric menu connector:

  • value is a simple number:number instead of stringified json
  • less conditions around refinement

still to do:

  • ensure all changes are correct and update the relevant tests

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c166f0b:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Haroenv