feat(chat): include in UMD build #6793
Conversation
Did not remove the umd file yet, as it's used by vue instantsearch and algolia-experiences bundles, which didn't get a change in setup.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b7e1292:
|
aymeric-giraudet
requested review from
a team,
aymeric-giraudet and
shaejaz
and removed request for
a team
|
Got it to work and tested on |
|
That's a much larger impact than I expected for chat. Is it all because of the dependencies or also because the chat widget/connector uses a lot of local code? |
| default as defaultConstructor, | ||
| } from 'algoliasearch/lite'; | ||
| import instantsearch from '../../src'; | ||
| import type instantsearch from '../../src'; |
There was a problem hiding this comment.
instantsearch is used as more than a type, maybe the import needs to be the umd version for storybook to avoid chat?
Haroenv
force-pushed
the
master
branch
3 times, most recently
from
c1fa2e8 to
9af869e
Compare
aymeric-giraudet
force-pushed
the
feat/chat-in-umd
branch
from
549bff4 to
232cc10
Compare
aymeric-giraudet
force-pushed
the
feat/chat-in-umd
branch
from
232cc10 to
b7e1292
Compare
| export const ZodFirstPartyTypeKind = {}; | ||
| export const toJSONSchema = {}; | ||
| export const safeParseAsync = {}; | ||
| export const z = new Proxy( |
There was a problem hiding this comment.
at which point is this evaluated? do we need to check if proxy exists first in case it gets evaluated in IE11?
There was a problem hiding this comment.
I'm ok with chat not working in IE11, but just ensuring that the entire InstantSearch doesn't throw
There was a problem hiding this comment.
Yeah the constructor does get called directly. There are polyfills though if we still actually care about the tests passing ?
There was a problem hiding this comment.
We may need to do typeof Proxy === 'object' ? new Proxy : null or similar to at least not have a global error thrown then? not sure how to check tbh, just asking
There was a problem hiding this comment.
It would still throw though cause zod schemas are created when the script is evaluated... so we'd have to define all those functions just for IE11 to work and make the bundle bigger
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
✅ but I can't approve it as I initially opened the PR
Did not remove the umd file yet, as it's used by vue instantsearch and algolia-experiences bundles, which didn't get a change in setup.
Summary
Result