feat(autocomplete): implement recent searches #6747
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0c9428:
|
aymeric-giraudet
force-pushed
the
feat/autocomplete-react-recent-searches
branch
2 times, most recently
from
0509ac1 to
44940ce
Compare
aymeric-giraudet
changed the title
aymeric-giraudet
force-pushed
the
feat/autocomplete-react-recent-searches
branch
3 times, most recently
from
0a8c374 to
efae04b
Compare
aymeric-giraudet
force-pushed
the
feat/autocomplete-react-recent-searches
branch
from
efae04b to
8f7e4a4
Compare
aymeric-giraudet
requested review from
a team,
FabienMotte and
Haroenv
and removed request for
a team
|
|
||
| const indicesForPropGetters = [...indices]; | ||
| const indicesConfigForPropGetters = [...indicesConfig]; | ||
| if (showRecent) { |
There was a problem hiding this comment.
this implies we're saving recent searches even if showRecent is false. Should maybe the whole storage be conditional based on showRecent?
There was a problem hiding this comment.
Can't call hooks conditionally but I could return a storage with empty function or something yeah
| } | ||
|
|
||
| const LOCAL_STORAGE_KEY_TEST = 'test-localstorage-support'; | ||
| const LOCAL_STORAGE_KEY = 'autocomplete-recent-searches'; |
There was a problem hiding this comment.
Is there some way where we link the autocomplete setup with the recent searches that are being presented? Do we do that in autocomplete.js?
What if there's multiple autocomplete instances in multiple places in the app?
There was a problem hiding this comment.
I think we could but the original lib doesn't, even though it does have code to handle multiple autocomplete components on a page (which I don't think anyone needs really)
Summary
FX-3504
Result