-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse the data to json before masking the properties #811
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ea1732
fix: parse the data to json before masking the properties
Bendakh e4262ff
chore: add comment to explain data parsing
Bendakh 1c9b574
chore: change variable name
Bendakh a7a5f26
feat: handle circular references
Bendakh 6020da3
chore: correct import
Bendakh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,31 +173,33 @@ export class LoggingInterceptor implements NestInterceptor { | |
* @returns the masked data | ||
*/ | ||
private maskData(data: unknown, maskingOptions: string[] | true, path: string = ''): unknown { | ||
const dataToMask = JSON.parse(JSON.stringify(data)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. parsedData would be more accurate. |
||
|
||
if (this.disableMasking) { | ||
return data; | ||
return dataToMask; | ||
} | ||
|
||
if (maskingOptions === true || maskingOptions.includes(path)) { | ||
return this.maskingPlaceholder; | ||
} | ||
|
||
if (Array.isArray(data)) { | ||
return data.map((item: unknown): unknown => this.maskData(item, maskingOptions, path)); | ||
if (Array.isArray(dataToMask)) { | ||
return dataToMask.map((item: unknown): unknown => this.maskData(item, maskingOptions, path)); | ||
} | ||
|
||
// eslint-disable-next-line no-null/no-null | ||
if (typeof data === 'object' && data !== null) { | ||
return Object.keys(data).reduce<object>((maskedObject: object, key: string): object => { | ||
if (typeof dataToMask === 'object' && dataToMask !== null) { | ||
return Object.keys(dataToMask).reduce<object>((maskedObject: object, key: string): object => { | ||
const nestedPath = path ? `${path}.${key}` : key; | ||
|
||
return { | ||
...maskedObject, | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
[key]: this.maskData((data as any)[key], maskingOptions, nestedPath), | ||
[key]: this.maskData((dataToMask as any)[key], maskingOptions, nestedPath), | ||
}; | ||
}, {}); | ||
} | ||
|
||
return data; | ||
return dataToMask; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment to say why we did this so it is clearer in the code ?