Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse the data to json before masking the properties #811

Merged
merged 5 commits into from
Nov 17, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/logging-interceptor/src/logging.interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,31 +173,33 @@ export class LoggingInterceptor implements NestInterceptor {
* @returns the masked data
*/
private maskData(data: unknown, maskingOptions: string[] | true, path: string = ''): unknown {
const dataToMask = JSON.parse(JSON.stringify(data));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment to say why we did this so it is clearer in the code ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsedData would be more accurate.


if (this.disableMasking) {
return data;
return dataToMask;
}

if (maskingOptions === true || maskingOptions.includes(path)) {
return this.maskingPlaceholder;
}

if (Array.isArray(data)) {
return data.map((item: unknown): unknown => this.maskData(item, maskingOptions, path));
if (Array.isArray(dataToMask)) {
return dataToMask.map((item: unknown): unknown => this.maskData(item, maskingOptions, path));
}

// eslint-disable-next-line no-null/no-null
if (typeof data === 'object' && data !== null) {
return Object.keys(data).reduce<object>((maskedObject: object, key: string): object => {
if (typeof dataToMask === 'object' && dataToMask !== null) {
return Object.keys(dataToMask).reduce<object>((maskedObject: object, key: string): object => {
const nestedPath = path ? `${path}.${key}` : key;

return {
...maskedObject,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
[key]: this.maskData((data as any)[key], maskingOptions, nestedPath),
[key]: this.maskData((dataToMask as any)[key], maskingOptions, nestedPath),
};
}, {});
}

return data;
return dataToMask;
}
}
Loading