fix(core): instantiate each sub-client exactly once in _spawn_completion_context - #163
Merged
Merged
Conversation
…ion_context Previously the first sub-client was constructed twice — once for `other_backend_client` and again inside the registration loop. With backends that hold expensive underlying state (HTTP connection pools, async clients, OS sockets), the duplicate carried real cost; with multi-backend Anthropic on macOS this showed up as a ~3-min hang at iter 2 of every multi-backend trajectory. Usage tracking also merged via dict.update, so the duplicate overwrote one of the two instances' usage summaries. Reuse `other_backend_client` for the first registration and only construct the remaining sub-clients in the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_spawn_completion_context, the first sub-client was constructed twice — once forother_backend_clientand again inside the registration loop. Reuseother_backend_clientfor the first registration and only construct the remaining sub-clients in the loop.Why it matters
dict.updateinlm_handler.py, so the duplicate instance overwrote one of the two clients' usage summaries.