Skip to content

Add county accessor to Mapbox result to match other geocoder result interfaces #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexreisner merged 1 commit into from
Feb 22, 2026
+10 −0
Merged

Add county accessor to Mapbox result to match other geocoder result interfaces #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/geocoder/results/mapbox.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ def city
data_part('place') || context_part('place')
end

def county
data_part('district') || context_part('district')
end

def state
data_part('region') || context_part('region')
end
Expand Down
6 changes: 6 additions & 0 deletions test/unit/lookups/mapbox_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def test_result_components
assert_equal "Madison Square Garden, 4 Penn Plz, New York, New York 10119, United States", result.place_name
assert_equal "4 Penn Plz", result.street
assert_equal "New York", result.city
assert_equal "New York County", result.county
assert_equal "New York", result.state
assert_equal "10119", result.postal_code
assert_equal "NY", result.state_code
Expand Down Expand Up @@ -69,6 +70,7 @@ def test_neighborhood_result
assert_equal "Logan Square, Chicago, Illinois, United States", result.place_name
assert_equal nil, result.street
assert_equal "Chicago", result.city
assert_equal "Cook County", result.county
assert_equal "Illinois", result.state
assert_equal "60647", result.postal_code
assert_equal "IL", result.state_code
Expand All @@ -84,6 +86,7 @@ def test_postcode_result
assert_equal "Chicago, Illinois 60647, United States", result.place_name
assert_equal nil, result.street
assert_equal "Chicago", result.city
assert_equal "Cook County", result.county
assert_equal "Illinois", result.state
assert_equal "60647", result.postal_code
assert_equal "IL", result.state_code
Expand All @@ -99,6 +102,7 @@ def test_place_result
assert_equal "Chicago, Illinois, United States", result.place_name
assert_equal nil, result.street
assert_equal "Chicago", result.city
assert_equal "Cook County", result.county
assert_equal "Illinois", result.state
assert_equal nil, result.postal_code
assert_equal "IL", result.state_code
Expand All @@ -114,6 +118,7 @@ def test_region_result
assert_equal "Illinois, United States", result.place_name
assert_equal nil, result.street
assert_equal nil, result.city
assert_equal nil, result.county
assert_equal "Illinois", result.state
assert_equal nil, result.postal_code
assert_equal "IL", result.state_code
Expand All @@ -129,6 +134,7 @@ def test_country_result
assert_equal "United States", result.place_name
assert_equal nil, result.street
assert_equal nil, result.city
assert_equal nil, result.county
assert_equal nil, result.state
assert_equal nil, result.postal_code
assert_equal nil, result.state_code
Expand Down