-
-
Notifications
You must be signed in to change notification settings - Fork 48
docs: enhance details & directions #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance details & directions #779
Conversation
alexandrevilain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution :) Two minors comments to fix before merging.
|
|
hi @alexandrevilain is there flakiness in the e2e test suite? (please see the CI checks). I also experienced flakiness in my PR #776. |
I also experienced failures when running the e2e suite locally. Since I'm just changing a markdown file, there must be a deeper issue. LMK if you need help looking at it |
|
@TheHiddenLayer you can see that e2e are green in this PR. |
|
@alexandrevilain but I think it needed a retry to get all green. Before, one of the checks was failing. You can see there were two attempts in the UI, but the history doesn't show it though (only shows the latest checks results). Anyways, thanks and LMK how it goes on your local. |



Changes: