Skip to content

Conversation

@TheHiddenLayer
Copy link
Contributor

Changes:

  • add missing dependencies
  • add directions for local temporal setup
  • add information on available test commands

Copy link
Owner

@alexandrevilain alexandrevilain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :) Two minors comments to fix before merging.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

@TheHiddenLayer
Copy link
Contributor Author

TheHiddenLayer commented Aug 2, 2024

hi @alexandrevilain is there flakiness in the e2e test suite? (please see the CI checks). I also experienced flakiness in my PR #776.

@TheHiddenLayer
Copy link
Contributor Author

hi @alexandrevilain is there flakiness in the e2e test suite? (please see the CI checks). I also experienced flakiness in my PR #776.

I also experienced failures when running the e2e suite locally. Since I'm just changing a markdown file, there must be a deeper issue. LMK if you need help looking at it

@alexandrevilain
Copy link
Owner

@TheHiddenLayer you can see that e2e are green in this PR.
I'll check if it's working on my computer

@alexandrevilain alexandrevilain merged commit 0396297 into alexandrevilain:main Aug 2, 2024
@TheHiddenLayer TheHiddenLayer deleted the update-docs branch August 2, 2024 20:05
@TheHiddenLayer
Copy link
Contributor Author

@alexandrevilain but I think it needed a retry to get all green. Before, one of the checks was failing. You can see there were two attempts in the UI, but the history doesn't show it though (only shows the latest checks results).

Anyways, thanks and LMK how it goes on your local.

@alexandrevilain alexandrevilain added the documentation Improvements or additions to documentation label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants