Skip to content

Fix return type of intent request util functions #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnaudcourtecuisse wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Fix return type of intent request util functions #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ask-sdk-core/lib/util/RequestEnvelopeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,9 @@ export function getDialogState(requestEnvelope : RequestEnvelope) : DialogState
*
* @param {RequestEnvelope} requestEnvelope
* @param {string} slotName
* @return {Slot}
* @return {Slot | null | undefined}
*/
export function getSlot(requestEnvelope : RequestEnvelope, slotName : string) : Slot {
export function getSlot(requestEnvelope : RequestEnvelope, slotName : string) : Slot | null | undefined {
if (getRequestType(requestEnvelope) === 'IntentRequest') {
const slots : {[key : string] : Slot} = (requestEnvelope.request as IntentRequest).intent.slots;
if (slots != null) {
Expand All @@ -200,9 +200,9 @@ export function getSlot(requestEnvelope : RequestEnvelope, slotName : string) :
*
* @param {RequestEnvelope} requestEnvelope
* @param {string} slotName
* @return {string}
* @return {string | null}
*/
export function getSlotValue(requestEnvelope : RequestEnvelope, slotName : string) : string {
export function getSlotValue(requestEnvelope : RequestEnvelope, slotName : string) : string | null {
if (getRequestType(requestEnvelope) === 'IntentRequest') {
const slot = getSlot(requestEnvelope, slotName);
if (slot) {
Expand All @@ -225,9 +225,9 @@ export function getSlotValue(requestEnvelope : RequestEnvelope, slotName : strin
*
* @param {RequestEnvelope} requestEnvelope
* @param {string} slotName
* @return {SlotValue}
* @return {SlotValue | null}
*/
export function getSlotValueV2(requestEnvelope : RequestEnvelope, slotName : string) : SlotValue {
export function getSlotValueV2(requestEnvelope : RequestEnvelope, slotName : string) : SlotValue | null {
const slot = getSlot(requestEnvelope, slotName);
if (slot && slot.slotValue) {
return slot.slotValue;
Expand Down