Skip to content

Replace About submenu with dialog to prevent GNOME Shell cutoff - #22

Merged
nstarke merged 3 commits into
mainfrom
claude/sleepy-euler-ow2e5k
Nov 6, 2026
Merged

nstarke merged 3 commits into
mainfrom
claude/sleepy-euler-ow2e5k

Conversation

@nstarke

@nstarke nstarke commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the About submenu with a native GTK AboutDialog to prevent the submenu from being cut off at the bottom of the screen in GNOME Shell, which doesn't scroll menus. Also consolidates usage limit information into single-line menu items with progress bars for better readability.

Key Changes

  • About Dialog: Converted the About submenu to a modal AboutDialog that displays version, website, and credits information

    • Dialog is reused and presented again on subsequent clicks
    • Automatically hides on response or delete events
    • Removes the need for manual URL opening in the menu
  • Menu Item Formatting: Refactored usage limit display to fit on single lines with progress bars

    • Progress bar now appears first on each line to ensure visual alignment
    • Format changed from two lines to one: {bar} {label}: {percent}%{mark}{reset_info}
    • Reduces menu height to prevent bottom items from being pushed off-screen
  • Test Updates: Updated test expectations to match new dialog behavior and single-line format

    • Verifies dialog is presented and reused correctly
    • Confirms dialog fields are set properly
    • Validates new menu item label format
  • Version Bump: Updated to v1.0.10

Implementation Details

  • The AboutDialog is lazily initialized on first use and stored as self.about
  • Subsequent activations call present() to bring the existing dialog to the foreground
  • Menu items now use a single-line format with the progress bar at the start for consistent visual alignment
  • Comments added explaining the rationale for using a dialog instead of submenu in GNOME Shell context

https://claude.ai/code/session_013mySqGaxmEpzEYU55y8U6X

GNOME Shell's AppIndicator menu unfolds submenus inline and cannot
scroll, so the About submenu at the bottom expanded off the screen.
About now opens a Gtk.AboutDialog, and each limit takes one menu line
(bar, label, percent, reset) instead of two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mySqGaxmEpzEYU55y8U6X
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mySqGaxmEpzEYU55y8U6X
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mySqGaxmEpzEYU55y8U6X
@nstarke
nstarke merged commit c9bbbed into main Nov 6, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants