Repository navigation
Tests: keep reset countdowns off a minute boundary (fixes windows-11-arm) - #20
Merged
Merged
Conversation
sample_data() and the widget test put the reset exactly 3h / 5h from now and expected "2h 59m" / "4h 59m", which relies on the clock having ticked between building the data and rendering it. On Windows on Arm with Python 3.11 the clock is coarse enough that both reads return the same instant, the countdown floors to "3h 00m", and test_tray_render_after_fetch failed. Put the resets half a minute short instead, as test_app.py already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_tray_render_after_fetchfailed on the newwindows-11-arm, 3.11leg after #18 was merged.sample_data()set the reset to exactly now + 3h and the test expected2h 59m. That only passes if the clock has ticked between building the data and rendering it. On Windows on Arm with Python 3.11 the clock is coarse enough that both reads return the same instant, so the countdown floors to3h 00m.test_widget.pyhad the same pattern with 5h. Both now put the reset half a minute short of the hour, astest_app.pyalready does.Separately, the
ubuntu-26.04, 3.13failure in the same run wasapt-get updategetting a 403 from packages.microsoft.com, a runner problem unrelated to the code.Test plan
pytest tests/test_tray.py tests/test_widget.pypasses locallywindows-11-arm🤖 Generated with Claude Code