Fix identification of OscillatorNode objects in Safari v14+. Fixes #146.#147
Open
jlyman wants to merge 1 commit intoalemangui:masterfrom
Open
Fix identification of OscillatorNode objects in Safari v14+. Fixes #146.#147jlyman wants to merge 1 commit intoalemangui:masterfrom
jlyman wants to merge 1 commit intoalemangui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a secondary identifier for checking that an object is an OscillatorNode, to be compatible with how WebKit (Safari) changed their object identifiers.
I ran the tests and they were all still green on Firefox. I additionally ran the tests on Safari (but did not change the
karma.config.jsfile to include Safari because I assume that many others will not have Safari available for test). The suite on Safari failed 11 tests, but I was able to correct two of them which were directly linked to this issue. I didn't look into the other failures. Everything should still be green on FF however.Fixes #146.