Add .abortOnError to opt a check out of continue-on-error - #376
Merged
Conversation
- Include the current project's `name` in the Markdown heading (`# CI checks for <name> (<scalaVersion>)`) so per-project / multi-project invocations produce distinct, identifiable blocks when several writes land on the same `$GITHUB_STEP_SUMMARY` file. - Use ✅ / ❌ in the console summary and the Markdown table instead of `PASS` / `FAIL`. - Drop the `-check` suffix from the built-in step labels (`scalafmt`, `scalafmt-sbt`, `scalafix`) since "check" is redundant in the `fix --check` / `ci` context.
`fix --check` runs every check even on failure so a single CI run surfaces every violation. For foundational checks (e.g. `compile`) running downstream checks after a failure is pointless. Marking a `NamedCheck` `.abortOnError` stops the chain on its failure; subsequent checks are reported as Skipped (⏭️) without being run. The default stays continue-on-error.
github-actions
Bot
added
🚀 feature
alejandrohdezma
force-pushed
the
feat/abort-on-error
branch
from
May 19, 2026 16:49
549149b to
207358d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 How to review this PR?
This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.
I also recommend checking "Hide whitespace" when reviewing this PR!
🚀 What's included in this PR?
nameis now included in the Markdown heading (# CI checks for <name> (<scalaVersion>)) so per-project / multi-project invocations produce distinct, identifiable blocks when several writes land on the same$GITHUB_STEP_SUMMARYfile; PASS/FAIL replaced with ✅ / ❌ emoji in the console summary and the Markdown table; built-in step labels shortened (scalafmt,scalafmt-sbt,scalafix) since "check" is redundant in thefix --check/cicontext..abortOnErrorcombinator onNamedCheck: opts a check out of the default continue-on-error semantics. When a check tagged.abortOnErrorfails, the remaining checks are marked Skipped (⏭️) without being run. The default stays continue-on-error sofix --checkkeeps surfacing every formatter/linter violation in one pass; the new combinator is for foundational checks (e.g.compile) where downstream checks after a failure are pointless.versionPolicyIntention := Compatibility.Nonefor this release, since adding a field to theNamedCheckcase class is a binary-incompatible signature change.