Use TryFrom over From #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
force-pushed
the
feature/try_into_selection
branch
2 times, most recently
from
2df478f to
c9b52c7
Compare
Closed
mulimoen
force-pushed
the
feature/try_into_selection
branch
from
70054de to
cc89b2d
Compare
mulimoen
force-pushed
the
feature/try_into_selection
branch
from
cc89b2d to
43ee34d
Compare
mulimoen
force-pushed
the
feature/try_into_selection
branch
2 times, most recently
from
972e402 to
5ffa3f9
Compare
|
@mulimoen Any changes/updates to this, do we want to rebase/merge it? (should changelog be updated then?) |
mulimoen
force-pushed
the
feature/try_into_selection
branch
from
5ffa3f9 to
252136f
Compare
|
This change is orthogonal to all other PRs. There is need for changes in the CHANGELOG, this overwrites the unreleased |
|
Yea, make sense, I've misread it. Could you rebase (just in case)? We'll wait till it's green and then merge |
|
@aldanor Rebased and green |
aldanor
approved these changes
Oct 13, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
Fromimplementations ofSliceOrIndex/Hyperslab/SelectiontoTryFrom.SliceOrIndexis now reworked to only accept parameters resulting in valid selections. The old code for working with negative strides in selections to allow python like negative indexing has been removed, which removed a lot of the special casing to allow for this.A future addition could be to introduce a hyperslab macro which mirrors
ndarray::s, but allows the size of the block to be selected.Fixes #142