fix #9 and #13 - #18
Open
bung87 wants to merge 3 commits into
Open
Conversation
Owner
|
Hey @bung87, thank you very much for the PR, CI is failing because of a test. Could you look into that? |
Author
yeah , I fixed it in Fit container branch. |
lazd
reviewed
Dec 3, 2019
| constructor(name, pkg, options) { | ||
| super(name, pkg, options); | ||
| constructor(name, options) { | ||
| super(name, options); |
There was a problem hiding this comment.
Could just super.apply(this, arguments) or super(...arguments) to future-proof this.
Author
There was a problem hiding this comment.
yeah , can do this, better change arguments to other name like args, arguments is a keyword.
There was a problem hiding this comment.
In this case, the use of the keyword is actually intended; we want to pass precisely the same arguments that were passed to us, to super(), so we do that with super(...arguments) (or the ES5 equivalent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.