[codex] Clarify TypeScript source and generated artifacts#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitattributesso GitHub language stats treat compiled package JS, declarations, golden fixtures, coverage, and example dist output as generated.src/**/*.tsthe contributor-facing source boundary..d.tsfiles are committed package artifacts generated bynpm run build:ts, while templates remain hand-written runtime sources.fast-uriinpackage-lock.jsonto 3.1.2 so the PR passes the current high-severitynpm auditgate.Why
The repository currently looks more JavaScript-heavy than it is because npm package artifacts and generated drift fixtures are committed. For OSS contributors, the project should make the editable source, generated artifacts, and package distribution boundary explicit.
Validation
git check-attr linguist-generated -- bin/cli.js src/bin/cli.ts scripts/compile.js src/scripts/compile.ts tests/golden/base/edge/viewer-request.js templates/aws/viewer-request.js src/types/policy.d.ts package-lock.jsonnpm audit --audit-level=highnpm run test:api-contractnpm run test:package