Fix flaky tab reordering test (openedx#20555)

alangsto · May 14, 2019 · 0b48665 · 0b48665
1 parent a6fce12
commit 0b48665
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/common/test/acceptance/tests/studio/test_studio_tabs.py b/common/test/acceptance/tests/studio/test_studio_tabs.py
@@ -127,18 +127,11 @@ def test_user_can_reorder_builtin_tabs(self):
             'Tabs are not in the default order'
         )
         self.pages_page.drag_and_drop(default_tab=True)
-        built_in_page_titles = self.pages_page.built_in_page_titles
-        self.assertEqual(
-            built_in_page_titles,
-            new_order,
-            'Tabs are not in the new order'
-        )
+        self.pages_page.wait_for(lambda: self.pages_page.built_in_page_titles == new_order,
+                                 'Tabs are in the new order')
         self.pages_page.refresh_and_wait_for_load()
-        self.assertEqual(
-            built_in_page_titles,
-            new_order,
-            'Tabs are not in the new order'
-        )
+        self.pages_page.wait_for(lambda: self.pages_page.built_in_page_titles == new_order,
+                                 'Tabs are in the new order')
 
     def test_users_can_toggle_visibility(self):
         """