isolate rooms and curriculum sections into 3 layer architecture #11#46
Open
IbrahimAhmed8 wants to merge 2 commits into
Open
isolate rooms and curriculum sections into 3 layer architecture #11#46IbrahimAhmed8 wants to merge 2 commits into
IbrahimAhmed8 wants to merge 2 commits into
Conversation
|
@IbrahimAhmed8 is attempting to deploy a commit to the akyourowngames' projects Team on Vercel. A member of the Team first needs to authorize it. |
IbrahimAhmed8
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the architecture refactoring outlined in #11 for the Rooms and Curriculum areas.
Architectural Changes:
RoomCardandCurriculumCardintodashboard/components/DashboardRoomsSectionand decoupled the embedded curriculum block into a standaloneDashboardCurriculumSectionDashboardDataContextandDashboardSectionShellinto isolated files to cleanly share state/UI without triggering circular dependenciesStudentDashboard.tsx, effectively reducing its bloat while retaining exact existing behavior and visualsNo visual regressions. Type-safe and verified locally