Skip to content

optimize LCP n fix a11y for icon buttons across dashboard #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
risuhfoundry merged 1 commit into from
Apr 10, 2026
Merged

optimize LCP n fix a11y for icon buttons across dashboard #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/dashboard/DashboardPersonalizationPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ export default function DashboardPersonalizationPanel({
onClick={closeModal}
aria-label="Close personalization flow"
>
<X size={18} />
<X size={18} aria-hidden="true" />
</button>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/features/dashboard/StudentDangerZoneSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export default function StudentDangerZoneSection({
onClick={closeModal}
aria-label="Close delete account modal"
>
<X size={18} />
<X size={18} aria-hidden="true" />
</button>
</div>

Expand Down
9 changes: 5 additions & 4 deletions src/features/dashboard/StudentDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use client';

import Image from 'next/image';
import dynamic from 'next/dynamic';
import Link from 'next/link';
import {
ArrowRight,
Expand Down Expand Up @@ -35,7 +36,7 @@ import {
type StudentDashboardRoom,
type StudentDashboardSkill,
} from './student-dashboard-model';
import YantraAmbientBackground from './YantraAmbientBackground';
const YantraAmbientBackground = dynamic(() => import('./YantraAmbientBackground'), { ssr: false });
import type {
DashboardCurriculumNode,
DashboardMomentumBar,
Expand Down Expand Up @@ -563,7 +564,7 @@ function DashboardNav() {
className="flex h-8 w-8 items-center justify-center rounded-full border border-white/12 bg-white/[0.04] text-white/70 transition-colors hover:bg-white/[0.08]"
aria-label="Student Profile"
>
<UserCircle2 size={16} />
<UserCircle2 size={16} aria-hidden="true" />
</Link>
<GlobalSidebar className="text-white hoverable" />
</div>
Expand Down Expand Up @@ -894,7 +895,7 @@ function OverviewSection({ view }: { view: DashboardViewModel }) {
})
}
>
<ArrowRight size={16} />
<ArrowRight size={16} aria-hidden="true" />
</button>
</div>
</div>
Expand Down Expand Up @@ -1230,7 +1231,7 @@ function YantraAiSection({ view }: { view: DashboardViewModel }) {
className="flex h-11 w-11 items-center justify-center rounded-full border border-white/10 bg-white text-black transition-colors hover:bg-white/92 hoverable"
aria-label="Send prompt"
>
<ArrowRight size={16} />
<ArrowRight size={16} aria-hidden="true" />
</button>
</div>
</form>
Expand Down
1 change: 1 addition & 0 deletions supabase/.branches/_current_branch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
main
1 change: 1 addition & 0 deletions supabase/.temp/cli-latest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v2.84.2
Loading