Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update 50-analysis-templates.md #3538

Merged
merged 1 commit into from
Apr 9, 2025
Merged

docs: Update 50-analysis-templates.md #3538

merged 1 commit into from
Apr 9, 2025

Conversation

Utwo
Copy link
Contributor

@Utwo Utwo commented Feb 21, 2025

I think here in order for the verification to pass, you will also need a count.

@Utwo Utwo requested review from a team as code owners February 21, 2025 20:40
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit dd5cf88
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67b8e4bda301fb0008c16514
😎 Deploy Preview https://deploy-preview-3538.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Utwo Utwo changed the title Update 50-analysis-templates.md docs: Update 50-analysis-templates.md Feb 21, 2025
@krancour
Copy link
Member

@jessesuen you know Rollouts better than myself or @hiddeco.

Would you be willing to review this one-liner?

@Utwo
Copy link
Contributor Author

Utwo commented Feb 23, 2025

@jessesuen you know Rollouts better than myself or @hiddeco.

Would you be willing to review this one-liner?

I'm not an expert on Rollouts as well but I've tried it locally and I only managed to make it pass using the above suggestion.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@krancour krancour merged commit e6b6e9d into akuity:main Apr 9, 2025
14 of 16 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
@akuitybot
Copy link

Successfully created backport PR for release-1.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants