Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Misc cleanup #71

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

patriknw
Copy link
Member

  • Remove EventSourcedEntitiesImpl
  • Remove KeyValueEntitiesImpl
  • Remove ActionsImpl
  • Collect spi descriptors in one loop
  • Remove commandId

On top of #70

*/
@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised that I removed this in workflow without deprecation cycle.

@patriknw patriknw force-pushed the wip-kve-spi-patriknw branch from e02cc1e to 133f262 Compare December 11, 2024 07:12
Base automatically changed from wip-kve-spi-patriknw to java-spi December 11, 2024 09:17
* Remove EventSourcedEntitiesImpl
* Remove KeyValueEntitiesImpl
* Remove ActionsImpl
* Collect spi descriptors in one loop
* Remove commandId
@patriknw patriknw force-pushed the wip-rm-EventSourcedEntitiesImpl-patriknw branch from 07be6aa to 7ba5378 Compare December 11, 2024 12:55
@patriknw patriknw marked this pull request as ready for review December 11, 2024 12:55
@aludwiko aludwiko merged commit 9fb9f6d into java-spi Dec 11, 2024
22 checks passed
@aludwiko aludwiko deleted the wip-rm-EventSourcedEntitiesImpl-patriknw branch December 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants