chore: consuming and producing without proto desc SDK changes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aludwiko
commented
Dec 6, 2024
| * @param any | ||
| * @param metadata | ||
| */ | ||
| class AnyInvocationContext(val any: ScalaPbAny, metadata: Metadata) extends InvocationContext(null, metadata) { |
There was a problem hiding this comment.
just a temporary solution, before I refactor commandHandler/methodInvokers
| def contentTypesFor(clz: Class[_]): List[String] = | ||
| lookupTypeHint(clz).allTypeHints.map(JsonContentTypePrefix + _) | ||
| def contentTypesFor(clz: Class[_]): List[String] = { | ||
| if (clz == classOf[Array[Byte]]) { |
There was a problem hiding this comment.
for byte arrays consumers
octonato
approved these changes
Dec 9, 2024
| @@ -9,6 +9,7 @@ | |||
| import akkajavasdk.components.workflowentities.*; | |||
| import akkajavasdk.components.workflowentities.hierarchy.TextWorkflow; | |||
| import org.awaitility.Awaitility; | |||
| import org.junit.jupiter.api.Disabled; | |||
There was a problem hiding this comment.
Ah, I will remove it in the next PR
patriknw
approved these changes
Dec 9, 2024
| @@ -24,30 +25,28 @@ private[impl] class ReflectiveConsumerRouter[A <: Consumer]( | |||
| ignoreUnknown: Boolean) | |||
| extends ConsumerRouter[A](consumer) { | |||
There was a problem hiding this comment.
In a separate PR you could try to remove ConsumerRouter. I don't think we need both ConsumerRouter and ReflectiveConsumerRouter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflows tests are disabled, but the rest are green