chore: Remove JsonMessageCodec #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Dec 6, 2024
patriknw
commented
- now fully replaced by JsonSerializer
* now fully replaced by JsonSerializer
patriknw
commented
Dec 6, 2024
| @@ -598,7 +597,7 @@ private final class Sdk( | |||
|
|
|||
| // FIXME pull this inline setup stuff out of SdkRunner and into some workflow class | |||
| val workflowStateType: Class[S] = Reflect.workflowStateType(workflow) | |||
| messageCodec.registerTypeHints(workflowStateType) | |||
| serializer.registerTypeHints(workflowStateType) | |||
There was a problem hiding this comment.
@octonato this is of importance for workflows
There was a problem hiding this comment.
yep, I just rebase and fixed my branch.
anyway, let's do it.
| @@ -610,7 +609,7 @@ private final class Sdk( | |||
| case callStep: Workflow.CallStep[_, _, _, _] => | |||
| List(callStep.callInputClass, callStep.transitionInputClass) | |||
| } | |||
| .foreach(messageCodec.registerTypeHints) | |||
| .foreach(serializer.registerTypeHints) | |||
octonato
approved these changes
Dec 6, 2024
| @@ -598,7 +597,7 @@ private final class Sdk( | |||
|
|
|||
| // FIXME pull this inline setup stuff out of SdkRunner and into some workflow class | |||
| val workflowStateType: Class[S] = Reflect.workflowStateType(workflow) | |||
| messageCodec.registerTypeHints(workflowStateType) | |||
| serializer.registerTypeHints(workflowStateType) | |||
There was a problem hiding this comment.
yep, I just rebase and fixed my branch.
anyway, let's do it.
|
build broken because SPI snapshot |
|
yes. we said we'll work with local snapshots until we have things in shape. some tests are failing as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.