feat: gRPC codegen config in parent pom #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually checked that this works nicely in the doc snippets which has a protobuf dir and another sample that does not. |
efgpinto
approved these changes
Jan 23, 2025
| <id>generate-protobuf-endpoints</id> | ||
| <activation> | ||
| <file> | ||
| <exists>src/main/protobuf</exists> |
There was a problem hiding this comment.
I thought the directory was usually proto? maybe it can be either? I think we use to have proto in samples?
There was a problem hiding this comment.
Ah, I'll change, IntelliJ suggests both (and we probably pick either up in Akka gRPC) but we indeed use proto Akka gRPC samples so let's go with that.
There was a problem hiding this comment.
For the record protobuf is the default in sbt/Scala projects
| throw new IllegalStateException( | ||
| s"SDK Akka gRPC plugin version is [$pluginVersion] but parent pom version is not the same [$parentPomAkkaGrpcVersion]. " + | ||
| s"Align $parentPomFile with the SDK build version to correct.") | ||
| } |
There was a problem hiding this comment.
Great to have this check in place. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A profile triggered by the existence of a src/main/protobuf enables the akka-grpc plugin with the right config.
Also adds validation that the grpc version in the parent pom and the SDK are aligned as a CI check.