Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: review multi-region concepts #152

Merged
merged 1 commit into from
Jan 15, 2025
Merged

docs: review multi-region concepts #152

merged 1 commit into from
Jan 15, 2025

Conversation

ennru
Copy link
Member

@ennru ennru commented Jan 15, 2025

  • Slight changes to the page structure.
  • Introduce references to the arrows in the description.

I'm considering to split the last image into more distinct steps to have less information in it.

image image

@github-actions github-actions bot added the documentation documentation related label Jan 15, 2025
beritou
beritou approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@beritou beritou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should double check with Rich on this approach of embedding number images in the text, to make sure there aren't unexpected consequences.

@rasummer
Copy link
Contributor

I can't think of any unexpected consequences doing it this way. LGTM

@beritou beritou merged commit 07dde66 into main Jan 15, 2025
4 checks passed
@beritou beritou deleted the ennru-multi-region branch January 15, 2025 17:05
@franciscolopezsancho franciscolopezsancho mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beritou beritou beritou approved these changes

Assignees
No one assigned
Labels
documentation documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ennru @rasummer @beritou