Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging workflow step and transition failures #146

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

aludwiko
Copy link
Contributor

No description provided.

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

} catch {
case CommandHandlerNotFound(name) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this dead-code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, I simplified this code before, and nothing throws this exception anymore

@aludwiko aludwiko merged commit d71aace into java-spi Jan 14, 2025
22 checks passed
@aludwiko aludwiko deleted the workflows-logging-exception branch January 14, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants